-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add union type to suppress deprecation warning #324
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.x #324 +/- ##
============================================
- Coverage 87.60% 87.60% -0.01%
Complexity 1749 1749
============================================
Files 349 349
Lines 4705 4704 -1
============================================
- Hits 4122 4121 -1
Misses 583 583
Flags with carried forward coverage won't be shown. Click here to find out more.
|
🤔 ...
|
InvalidArgument: Argument 2 of Http\Promise\Promise::then expects callable(Exception):mixed|null, but impure-Closure(Http\Client\Exception):mixed provided
I do not know why I could not reproduce the issue locally but I managed to fix it... 💯 :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @mxr576 for the fix, I was locally able to replicate the psalm error and the fix looks good. |
Closes #323