Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List only API products purchased by a team for m10n #336

Closed
wants to merge 8 commits into from

Conversation

kedarkhaire
Copy link
Collaborator

Fixes #335

@kedarkhaire kedarkhaire added the enhancement New feature or request label Dec 27, 2023
@kedarkhaire kedarkhaire added this to the 3.0.4 milestone Dec 27, 2023
@kedarkhaire kedarkhaire changed the title Issue 335 3x List only API products purchased by a team for m10n Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (f0b1790) 87.71% compared to head (be4c4a2) 86.12%.

❗ Current head be4c4a2 differs from pull request most recent head 427c80a. Consider uploading reports for the commit 427c80a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #336      +/-   ##
============================================
- Coverage     87.71%   86.12%   -1.60%     
- Complexity     1751     1779      +28     
============================================
  Files           349      354       +5     
  Lines          4713     4785      +72     
============================================
- Hits           4134     4121      -13     
- Misses          579      664      +85     
Flag Coverage Δ
unittests 86.12% <0.00%> (-1.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Converter/CompanyEligibleRatePlanNameConverter.php 0.00% <0.00%> (ø)
...n/Normalizer/CompanyEligibleRatePlanNormalizer.php 0.00% <0.00%> (ø)
...normalizer/CompanyEligibleRatePlanDenormalizer.php 0.00% <0.00%> (ø)
...n/Controller/CompanyEligibleRatePlanController.php 0.00% <0.00%> (ø)
...tization/Controller/EligibleRatePlanController.php 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@kedarkhaire kedarkhaire marked this pull request as ready for review December 28, 2023 15:35
@shishir-intelli shishir-intelli removed this from the 3.0.4 milestone Jan 10, 2024
@kedarkhaire
Copy link
Collaborator Author

Closing this PR as these changes wont be required.

@kedarkhaire kedarkhaire closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for list only API products purchased by a team used in m10n teams
3 participants