Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Team app credentials listings sorted in ascending order #337

Merged
merged 7 commits into from
Jan 10, 2024

Conversation

kedarkhaire
Copy link
Collaborator

@kedarkhaire kedarkhaire commented Jan 8, 2024

Closes #338

@kedarkhaire kedarkhaire added the bug Something isn't working label Jan 8, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (53181d7) 87.60% compared to head (1b59f58) 87.60%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                3.x     #337   +/-   ##
=========================================
  Coverage     87.60%   87.60%           
  Complexity     1750     1750           
=========================================
  Files           349      349           
  Lines          4704     4705    +1     
=========================================
+ Hits           4121     4122    +1     
  Misses          583      583           
Flag Coverage Δ
unittests 87.60% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Api/Management/Entity/App.php 89.47% <50.00%> (+0.28%) ⬆️

@kedarkhaire kedarkhaire marked this pull request as ready for review January 9, 2024 14:04
Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kedarkhaire kedarkhaire merged commit 189c2dc into apigee:3.x Jan 10, 2024
5 checks passed
@shishir-intelli shishir-intelli added this to the 3.0.4 milestone Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Team app credentials listings are not in sorting order on the team app page.
3 participants