Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute values lost in PUT call while creating AppGroup #340

Merged
merged 8 commits into from
Jan 10, 2024

Conversation

shishir-intelli
Copy link
Collaborator

Closes #339

AppGroup do not have separate API for getting AppGroup attributes so implemented getAppGroupAttributes() method interface to get all attributes from AppGroup.

@shishir-intelli shishir-intelli added the bug Something isn't working label Jan 9, 2024
@shishir-intelli shishir-intelli added this to the 3.0.4 milestone Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (189c2dc) 87.60% compared to head (ce5d2f4) 87.62%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #340      +/-   ##
============================================
+ Coverage     87.60%   87.62%   +0.02%     
- Complexity     1750     1751       +1     
============================================
  Files           349      349              
  Lines          4705     4713       +8     
============================================
+ Hits           4122     4130       +8     
  Misses          583      583              
Flag Coverage Δ
unittests 87.62% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...i/ApigeeX/Controller/AppGroupMembersController.php 85.29% <100.00%> (+4.52%) ⬆️

Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit 14b01a8 into apigee:3.x Jan 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Custom field/attribute value not updated while creating new AppGroup
2 participants