Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2x - Fix for Team app credentials listings sorted in ascending order #346

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

kedarkhaire
Copy link
Collaborator

Fixes #338 for 2x

@kedarkhaire kedarkhaire added the bug Something isn't working label Jan 11, 2024
@kedarkhaire kedarkhaire added this to the 2.1.4 milestone Jan 11, 2024
@kedarkhaire kedarkhaire deleted the issue-2x-338 branch January 11, 2024 15:55
@kedarkhaire kedarkhaire restored the issue-2x-338 branch February 13, 2024 08:11
@kedarkhaire kedarkhaire reopened this Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9f2fc0a) 87.55% compared to head (0d6b003) 87.55%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #346   +/-   ##
=========================================
  Coverage     87.55%   87.55%           
  Complexity     1728     1728           
=========================================
  Files           349      349           
  Lines          4613     4614    +1     
=========================================
+ Hits           4039     4040    +1     
  Misses          574      574           
Flag Coverage Δ
unittests 87.55% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Api/Management/Entity/App.php 89.47% <50.00%> (+0.28%) ⬆️

@shishir-intelli shishir-intelli changed the title Fix for Team app credentials listings sorted in ascending order 2x - Fix for Team app credentials listings sorted in ascending order Feb 13, 2024
Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kedarkhaire kedarkhaire merged commit 80d40b8 into apigee:2.x Feb 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants