Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2x -Fix for Team 1000+ listing, AppGroup edit error and custom attribute update issues - 2x branch #353

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

shishir-intelli
Copy link
Collaborator

Fix for 2x #343, #351 and #339

@shishir-intelli shishir-intelli added the bug Something isn't working label Feb 12, 2024
@shishir-intelli shishir-intelli added this to the 2.1.4 milestone Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (80d40b8) 87.55% compared to head (febd75c) 87.51%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #353      +/-   ##
============================================
- Coverage     87.55%   87.51%   -0.05%     
- Complexity     1728     1731       +3     
============================================
  Files           349      349              
  Lines          4614     4620       +6     
============================================
+ Hits           4040     4043       +3     
- Misses          574      577       +3     
Flag Coverage Δ
unittests 87.51% <68.42%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...i/ApigeeX/Controller/AppGroupMembersController.php 85.29% <100.00%> (+4.52%) ⬆️
src/Api/ApigeeX/Entity/AppGroup.php 100.00% <ø> (+36.36%) ⬆️
...c/Api/ApigeeX/Controller/PaginationHelperTrait.php 80.00% <40.00%> (-17.62%) ⬇️

@shishir-intelli shishir-intelli changed the title Fix- Team 1000+ listing, AppGroup edit error and custom attribute update issues - 2x branch 2x -Fix for Team 1000+ listing, AppGroup edit error and custom attribute update issues - 2x branch Feb 12, 2024
composer.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@kedarkhaire kedarkhaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit 1130a80 into apigee:2.x Feb 13, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

3 participants