Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#334] Add content and API search #361

Closed
wants to merge 1 commit into from

Conversation

shadcn
Copy link
Contributor

@shadcn shadcn commented May 4, 2020

API search has been requested a few times. See #289, #298 and #334.

Since api_doc is a custom entity type, core search module cannot index it.

This PR adds an experimental apigee_kickstart_search module that ships with a search page for both content (article, landing page, faq and forum) and api_doc.

apigee_kickstart_search is a drop-in replacement for the default search. It has a dependency on the search_api module.

See also the README in this PR.

@googlebot googlebot added the cla: yes Indicates CLA has been signed label May 4, 2020
@shadcn shadcn requested review from arlina-espinoza and cnovak May 4, 2020 12:41
@shadcn shadcn marked this pull request as draft May 4, 2020 15:48
@cnovak
Copy link
Collaborator

cnovak commented May 4, 2020

@arshad I think this is not going to be needed or will need to change after @arlina-espinoza finishes her changes for the API Catalog to add RBAC. The APIDoc entity is being removed and will be a content type after her change. You probably want to put this on hold until she adds a PR for that issue.

@shadcn
Copy link
Contributor Author

shadcn commented May 6, 2020

@cnovak Thanks. I added a comment to the ticket. I'm going to close this PR.

@shadcn shadcn closed this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants