Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue2x #576 #914

Merged
merged 19 commits into from
Sep 8, 2023
Merged

Issue2x #576 #914

merged 19 commits into from
Sep 8, 2023

Conversation

kedarkhaire
Copy link
Collaborator

@kedarkhaire kedarkhaire commented Aug 18, 2023

Fixes #576 for 2.x branch
Changes are made for callbackURL field,
Fixed PHPCS issues
Updates are written in install file for callback url field
Added required testcases based on new regex.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #914 (afd6ddd) into 2.x (48c7800) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #914   +/-   ##
=========================================
  Coverage     43.95%   43.95%           
  Complexity     3039     3039           
=========================================
  Files           345      345           
  Lines         11166    11166           
=========================================
  Hits           4908     4908           
  Misses         6258     6258           
Files Changed Coverage Δ
src/Entity/App.php 88.63% <ø> (ø)
src/Entity/AppViewBuilder.php 0.00% <ø> (ø)
src/Form/AppCallbackUrlSettingsForm.php 0.00% <0.00%> (ø)
.../Plugin/Field/FieldWidget/AppCallbackUrlWidget.php 0.00% <ø> (ø)

@kedarkhaire kedarkhaire marked this pull request as ready for review August 29, 2023 13:05
Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kedarkhaire kedarkhaire merged commit aa3d60d into apigee:2.x Sep 8, 2023
@divya-intelli divya-intelli added this to the 2.1.2 milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants