-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements for adding filter with ChannelId on condition #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kedarkhaire
requested review from
giteshk,
shishir-intelli and
divya-intelli
September 22, 2023 15:45
shishir-intelli
added
enhancement
New feature or request
and removed
apigee_edge
apigee_edge_teams
labels
Sep 26, 2023
Fixes #947 |
kedarkhaire
force-pushed
the
appgroups-filter-3x
branch
from
October 4, 2023 13:56
2582d69
to
8f9a20f
Compare
kedarkhaire
force-pushed
the
appgroups-filter-3x
branch
from
October 5, 2023 11:21
fc33ab5
to
7a798e9
Compare
shishir-intelli
requested changes
Oct 9, 2023
modules/apigee_edge_teams/src/Entity/Controller/TeamController.php
Outdated
Show resolved
Hide resolved
modules/apigee_edge_teams/src/Entity/Controller/TeamController.php
Outdated
Show resolved
Hide resolved
src/Entity/Controller/CachedPaginatedEntityListingControllerTrait.php
Outdated
Show resolved
Hide resolved
shishir-intelli
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Config form of Teams Settings form.
Changes for condition based query parameter addition