Locked version mglaman/phpstan-drupal to 1.2.0

[shishir-intelli]

Temporary locked mglaman/phpstan-drupal version to 1.2.0, latest version of mglaman/phpstan-drupal is causing error durning Drupal-check.

Error: Internal error: Internal error: Cannot create PHPStan\Type\UnionType with: Drupal\apigee_edge\SDKConnector, Drupal\apigee_edge_debug\SDKConnector|Drupal\apigee_edge_test\SDKConnector while analysing file

We need to remove the locked version once we resolve the above issue.
Issue created here to rollback the changes.

[divya-intelli]

LGTM

[mxr576]

Is this a bug in this code or in mglaman/phpstan-drupal? If the latter, was this reported? Is there an issue reference in mglaman/phpstan-drupal?

[mxr576]

Probably this was caused by mglaman/phpstan-drupal#615

[shishir-intelli]

Probably this was caused by mglaman/phpstan-drupal#615

Ah okay, probably!
We will update mglaman/phpstan-drupal version to latest once the issue identified and resolved.

[mglaman]

Interesting. I wonder why those three classes cannot be considered a union. Can you open an issue for phpstan-drupal about this? It'd be helpful if you could link to those three classes so I can review them.

[mxr576]

(Summoned Matt on Drupal Slack, thanks for jumping in! :) )

I wonder why those three classes cannot be considered a union.

Had the same question in my head, but did not have time to check it. I'd start there...