Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for field_ui module enabled durning getting field prefix #988

Open
wants to merge 5 commits into
base: 3.x
Choose a base branch
from
+9 −0
Open

Added check for field_ui module enabled durning getting field prefix #988

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d7cdb3a
Fix field prefix issue
shishir-intelli Nov 21, 2023
8430e7a
Merge branch 'apigee:3.x' into issue_983
shishir-intelli Dec 1, 2023
1283683
Added Field UI module dependency
shishir-intelli Dec 1, 2023
b5a8d04
Merge branch '3.x' into issue_983
shishir-intelli Dec 7, 2023
ce42c59
Merge branch '3.x' into issue_983
kedarkhaire Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apigee_edge.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ core_version_requirement: ^10

dependencies:
- drupal:file
- drupal:field_ui
- drupal:user
- entity:entity
- drupal:filter
Expand Down
8 changes: 8 additions & 0 deletions apigee_edge.install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,3 +389,11 @@ function apigee_edge_update_9002() {
$edge_settings['content']['callbackUrl'] = $new_edge_settings['content']['callbackUrl'];
$config_storage->write('core.entity_view_display.developer_app.developer_app.default', $edge_settings);
}

/**
* Install Field UI module to maintain dependency.
*/
function apigee_edge_update_9003() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update hook for Drupal 10+ should start with 10.

https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Extension%21module.api.php/function/hook_update_N/10

(Probably old update hooks should have been removed when 3.x branch started and Drupal core major version was bumped)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update hook for Drupal 10+ should start with 10.

Thanks! Noted 👍

(Probably old update hooks should have been removed when 3.x branch started and Drupal core major version was bumped)

We will take care regarding this next time.

// Installing the field UI module.
\Drupal::service('module_installer')->install(['field_ui']);
}