Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate classes that is dependent on drupal/console #989

Merged
merged 5 commits into from
Nov 24, 2023
Merged

Deprecate classes that is dependent on drupal/console #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fdc815d
Deprecated classes that is dependent on drupal/console
divya-intelli Nov 22, 2023
aca8444
ignore these files as they contain deprecated class
divya-intelli Nov 22, 2023
7ec1078
ignore these files as they contain deprecated class
divya-intelli Nov 22, 2023
0da9009
ignore these files as they contain deprecated class
divya-intelli Nov 22, 2023
3e4c004
ignore these files as they contain deprecated class
divya-intelli Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Command/CommandBase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

namespace Drupal\apigee_edge\Command;

@trigger_error('The ' . __NAMESPACE__ . '\CommandBase is deprecated in apigee_edge:3.0.4 and is removed from apigee_edge:3.1.0. Drupal/console is not compatible with Drupal 10. See https://github.com/apigee/apigee-edge-drupal/issues/984', E_USER_DEPRECATED);

use Drupal\apigee_edge\CliServiceInterface;
use Drupal\Console\Core\Command\Command;
use Drupal\Console\Core\Command\Shared\CommandTrait;
Expand All @@ -32,6 +34,11 @@

/**
* Class CommandBase for shared functionality.
*
* @deprecated in apigee_edge:3.0.4 and is removed from apigee_edge:3.1.0.
* Drupal/console is not compatible with Drupal 10.
*
* @see https://github.com/apigee/apigee-edge-drupal/issues/984
*/
abstract class CommandBase extends Command {

Expand Down
6 changes: 6 additions & 0 deletions src/Command/CreateEdgeRoleCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@
* extension="apigee_edge",
* extensionType="module"
* )
*
* @deprecated in apigee_edge:3.0.4 and is removed from apigee_edge:3.1.0.
* Drupal/console is not compatible with Drupal 10.
*
* @see https://github.com/apigee/apigee-edge-drupal/issues/984
* @phpstan-ignore-next-line
*/
class CreateEdgeRoleCommand extends CommandBase {

Expand Down
6 changes: 6 additions & 0 deletions src/Command/DeveloperSyncCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@
* extension="apigee_edge",
* extensionType="module"
* )
*
* @deprecated in apigee_edge:3.0.4 and is removed from apigee_edge:3.1.0.
* Drupal/console is not compatible with Drupal 10.
*
* @see https://github.com/apigee/apigee-edge-drupal/issues/984
* @phpstan-ignore-next-line
*/
class DeveloperSyncCommand extends CommandBase {

Expand Down
5 changes: 5 additions & 0 deletions src/Command/DrupalConsoleLog.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@

/**
* Redirects Drupal logging messages to Drupal Console log.
*
* @deprecated in apigee_edge:3.0.4 and is removed from apigee_edge:3.1.0.
* Drupal/console is not compatible with Drupal 10.
*
* @see https://github.com/apigee/apigee-edge-drupal/issues/984
*/
class DrupalConsoleLog implements LoggerInterface {

Expand Down
2 changes: 2 additions & 0 deletions tests/src/Unit/Command/CreateEdgeRoleCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
* Test ApigeeEdgeCommands class.
*
* @group apigee_edge
*
* @group legacy
*/
class CreateEdgeRoleCommandTest extends UnitTestCase {

Expand Down