Fix for attach view to teams error for 2.x #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divya-intelli
requested review from
giteshk,
kedarkhaire and
shishir-intelli
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #996 +/- ##
=========================================
Coverage 43.91% 43.91%
Complexity 3027 3027
=========================================
Files 344 344
Lines 11138 11138
=========================================
Hits 4891 4891
Misses 6247 6247 |
|
@boobaa , can you please sign the CLA. I have added you as Co-authored for this PR. |
|
Yeah, thank you for doing that, but I don't have and never used such an email address. Please use the email address I have used for all other commits, thank you. |
Co-authored-by: CSÉCSY László <[email protected]>, <[email protected]>
divya-intelli
force-pushed
the
patch-958-2x
branch
from
058da45 to
ac8982c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally fixed by @boobaa
Closes #958.