Fix for rateplan issue when developer is not present (#442)

apigee · Aug 29, 2023 · 3ddaa1b · 3ddaa1b
1 parent bf25f8f
commit 3ddaa1b
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/Entity/Access/RatePlanSubscriptionAccessHandler.php b/src/Entity/Access/RatePlanSubscriptionAccessHandler.php
@@ -96,10 +96,13 @@ public function access(RatePlanInterface $rate_plan_entity, UserInterface $accou
     // If rate plan is a developer rate plan, and the assigned developer is
     // different from account, deny access.
     if ($rate_plan instanceof DeveloperRatePlanInterface) {
-      if ($developer = $rate_plan->getDeveloper()) {
+      $developer = $rate_plan->getDeveloper();
+      if ($developer) {
         return AccessResult::allowedIf($account->getEmail() === $developer->getEmail());
       }
-      return AccessResult::forbidden("User {$developer->getEmail()} cannot subscribe to developer rate plan.");
+      else {
+        return AccessResult::forbidden("Missing developer reference on {$rate_plan->id()} rate plan.");
+      }
     }
 
     if ($rate_plan instanceof CompanyRatePlanInterface) {