Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 10.3 test job added in workflow & CACHE_MISS_IF_UNCACHEABLE_HTTP_METHOD tag in Prepaid balance controller #501

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

kedarkhaire
Copy link
Collaborator

@kedarkhaire kedarkhaire commented Sep 19, 2024

Fixes #494

Failing in testcases was missing the expected CACHE_MISS_IF_UNCACHEABLE_HTTP_METHOD tag.
Solution added in reference of Drupal Change records.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.08%. Comparing base (f8e8c85) to head (27f90ef).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #501   +/-   ##
=========================================
  Coverage     49.08%   49.08%           
  Complexity     2001     2001           
=========================================
  Files           200      200           
  Lines          7405     7405           
=========================================
  Hits           3635     3635           
  Misses         3770     3770           

Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kedarkhaire kedarkhaire changed the title Support added for Drupal 10.3 Drupal 10.3 testcases added in workflow & fix for missing CACHE_MISS_IF_UNCACHEABLE_HTTP_METHOD tag is added Oct 1, 2024
@shishir-intelli shishir-intelli changed the title Drupal 10.3 testcases added in workflow & fix for missing CACHE_MISS_IF_UNCACHEABLE_HTTP_METHOD tag is added Drupal 10.3 test job added in workflow & CACHE_MISS_IF_UNCACHEABLE_HTTP_METHOD tag in Prepaid balance controller Oct 1, 2024
@kedarkhaire kedarkhaire merged commit a9b6fcf into apigee:2.x Oct 1, 2024
7 checks passed
@kedarkhaire kedarkhaire self-assigned this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drupal 10.3 compatibility for Apigee M10n
2 participants