bug: adds validation for siteid #349 (#350)

* bug: adds validation for siteid #349 * chore: fix linting issues #349
apigee · Dec 12, 2023 · 40cac48 · 40cac48
1 parent 42d0e76
commit 40cac48
Show file tree

Hide file tree

Showing 10 changed files with 46 additions and 2 deletions.
diff --git a/cmd/apicategories/create.go b/cmd/apicategories/create.go
@@ -15,6 +15,8 @@
 package apicategories
 
 import (
+	"fmt"
+
 	"internal/apiclient"
 
 	"internal/client/apicategories"
@@ -31,6 +33,9 @@ var CreateCmd = &cobra.Command{
 		return apiclient.SetApigeeOrg(org)
 	},
 	RunE: func(cmd *cobra.Command, args []string) (err error) {
+		if siteid == "" {
+			return fmt.Errorf("siteid is a mandatory parameter")
+		}
 		_, err = apicategories.Create(siteid, name)
 		return
 	},

diff --git a/cmd/apicategories/delete.go b/cmd/apicategories/delete.go
@@ -15,6 +15,8 @@
 package apicategories
 
 import (
+	"fmt"
+
 	"internal/apiclient"
 	"internal/client/apicategories"
 
@@ -30,6 +32,9 @@ var DelCmd = &cobra.Command{
 		return apiclient.SetApigeeOrg(org)
 	},
 	RunE: func(cmd *cobra.Command, args []string) (err error) {
+		if siteid == "" {
+			return fmt.Errorf("siteid is a mandatory parameter")
+		}
 		_, err = apicategories.Delete(siteid, id)
 		return
 	},

diff --git a/cmd/apicategories/get.go b/cmd/apicategories/get.go
@@ -15,6 +15,8 @@
 package apicategories
 
 import (
+	"fmt"
+
 	"internal/apiclient"
 
 	"internal/client/apicategories"
@@ -31,6 +33,9 @@ var GetCmd = &cobra.Command{
 		return apiclient.SetApigeeOrg(org)
 	},
 	RunE: func(cmd *cobra.Command, args []string) (err error) {
+		if siteid == "" {
+			return fmt.Errorf("siteid is a mandatory parameter")
+		}
 		_, err = apicategories.Get(siteid, id)
 		return
 	},

diff --git a/cmd/apicategories/list.go b/cmd/apicategories/list.go
@@ -15,6 +15,8 @@
 package apicategories
 
 import (
+	"fmt"
+
 	"internal/apiclient"
 	"internal/client/apicategories"
 
@@ -27,6 +29,9 @@ var ListCmd = &cobra.Command{
 	Short: "Returns the API categories associated with a portal",
 	Long:  "Returns the API categories associated with a portal",
 	Args: func(cmd *cobra.Command, args []string) (err error) {
+		if siteid == "" {
+			return fmt.Errorf("siteid is a mandatory parameter")
+		}
 		return apiclient.SetApigeeOrg(org)
 	},
 	RunE: func(cmd *cobra.Command, args []string) (err error) {

diff --git a/cmd/apidocs/create.go b/cmd/apidocs/create.go
@@ -43,7 +43,9 @@ var CreateCmd = &cobra.Command{
 		if err != nil {
 			return fmt.Errorf("require-callback-url must be a boolean value: %v", err)
 		}
-
+		if siteid == "" {
+			return fmt.Errorf("siteid is a mandatory parameter")
+		}
 		return apiclient.SetApigeeOrg(org)
 	},
 	RunE: func(cmd *cobra.Command, args []string) (err error) {

diff --git a/cmd/apidocs/delete.go b/cmd/apidocs/delete.go
@@ -15,6 +15,8 @@
 package apidocs
 
 import (
+	"fmt"
+
 	"internal/apiclient"
 	"internal/client/apidocs"
 
@@ -27,6 +29,9 @@ var DelCmd = &cobra.Command{
 	Short: "Deletes a catalog item",
 	Long:  "Deletes a catalog item",
 	Args: func(cmd *cobra.Command, args []string) (err error) {
+		if siteid == "" {
+			return fmt.Errorf("siteid is a mandatory parameter")
+		}
 		return apiclient.SetApigeeOrg(org)
 	},
 	RunE: func(cmd *cobra.Command, args []string) (err error) {

diff --git a/cmd/apidocs/get.go b/cmd/apidocs/get.go
@@ -15,6 +15,8 @@
 package apidocs
 
 import (
+	"fmt"
+
 	"internal/apiclient"
 	"internal/client/apidocs"
 
@@ -27,6 +29,9 @@ var GetCmd = &cobra.Command{
 	Short: "Gets a catalog item",
 	Long:  "Gets a catalog item",
 	Args: func(cmd *cobra.Command, args []string) (err error) {
+		if siteid == "" {
+			return fmt.Errorf("siteid is a mandatory parameter")
+		}
 		return apiclient.SetApigeeOrg(org)
 	},
 	RunE: func(cmd *cobra.Command, args []string) (err error) {

diff --git a/cmd/apidocs/getdocs.go b/cmd/apidocs/getdocs.go
@@ -15,6 +15,8 @@
 package apidocs
 
 import (
+	"fmt"
+
 	"internal/apiclient"
 	"internal/client/apidocs"
 
@@ -27,6 +29,9 @@ var GetDocCmd = &cobra.Command{
 	Short: "Gets the documentation for the specified catalog item",
 	Long:  "Gets the documentation for the specified catalog item",
 	Args: func(cmd *cobra.Command, args []string) (err error) {
+		if siteid == "" {
+			return fmt.Errorf("siteid is a mandatory parameter")
+		}
 		return apiclient.SetApigeeOrg(org)
 	},
 	RunE: func(cmd *cobra.Command, args []string) (err error) {

diff --git a/cmd/apidocs/list.go b/cmd/apidocs/list.go
@@ -15,6 +15,8 @@
 package apidocs
 
 import (
+	"fmt"
+
 	"internal/apiclient"
 	"internal/client/apidocs"
 
@@ -27,6 +29,9 @@ var ListCmd = &cobra.Command{
 	Short: "Returns the catalog items associated with a portal",
 	Long:  "Returns the catalog items associated with a portal",
 	Args: func(cmd *cobra.Command, args []string) (err error) {
+		if siteid == "" {
+			return fmt.Errorf("siteid is a mandatory parameter")
+		}
 		return apiclient.SetApigeeOrg(org)
 	},
 	RunE: func(cmd *cobra.Command, args []string) (err error) {

diff --git a/cmd/apidocs/update.go b/cmd/apidocs/update.go
@@ -44,7 +44,9 @@ var UpdateCmd = &cobra.Command{
 		if err != nil {
 			return fmt.Errorf("require-callback-url must be a boolean value: %v", err)
 		}
-
+		if siteid == "" {
+			return fmt.Errorf("siteid is a mandatory parameter")
+		}
 		return apiclient.SetApigeeOrg(org)
 	},
 	RunE: func(cmd *cobra.Command, args []string) (err error) {