Skip to content

Commit

Permalink
bug: sets safedeploy to false #515 (#516)
Browse files Browse the repository at this point in the history
  • Loading branch information
srinandan authored Jul 29, 2024
1 parent ad4b048 commit ac030f9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion internal/cmd/apis/bundlecrtapis.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ func init() {
BundleCreateCmd.Flags().BoolVarP(&sequencedRollout, "sequencedrollout", "",
false, "If set to true, the routing rules will be rolled out in a safe order; default is false")
BundleCreateCmd.Flags().BoolVarP(&safeDeploy, "safedeploy", "",
true, deploymentMsg)
false, deploymentMsg)
BundleCreateCmd.Flags().StringVarP(&serviceAccountName, "sa", "s",
"", "The format must be {ACCOUNT_ID}@{PROJECT}.iam.gserviceaccount.com.")
BundleCreateCmd.Flags().StringVarP(&desc, "desc", "d",
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/apis/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
)

const deploymentMsg = "When set to true, generateDeployChangeReport will be executed and " +
"deployment will proceed if there are no conflicts; default is false"
"deployment will proceed if there are no conflicts"

func GetRevision(respBody []byte) (revision int, err error) {
var apiProxyRevResp map[string]interface{}
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/apis/oascrtapisv2.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ func init() {
OasCreatev2Cmd.Flags().BoolVarP(&sequencedRollout, "sequencedrollout", "",
false, "If set to true, the routing rules will be rolled out in a safe order; default is false")
OasCreatev2Cmd.Flags().BoolVarP(&safeDeploy, "safedeploy", "",
true, deploymentMsg)
false, deploymentMsg)
OasCreatev2Cmd.Flags().StringVarP(&serviceAccountName, "sa", "s",
"", "The format must be {ACCOUNT_ID}@{PROJECT}.iam.gserviceaccount.com.")
OasCreatev2Cmd.Flags().StringVarP(&desc, "desc", "d",
Expand Down

0 comments on commit ac030f9

Please sign in to comment.