Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AssignMessage hygiene checks #417

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Conversation

DinoChiesa
Copy link
Collaborator

checks for presence of elements, proper placement, etc.

checks for presence of elements, proper placement, etc.
@DinoChiesa DinoChiesa marked this pull request as draft January 13, 2024 00:06
@DinoChiesa
Copy link
Collaborator Author

Wait, this is a work-in-progress. Some adjustments coming.

@DinoChiesa DinoChiesa marked this pull request as ready for review January 13, 2024 02:16
@ssvaidyanathan
Copy link
Collaborator

is this done so that I can review?

@DinoChiesa
Copy link
Collaborator Author

Yes @ssvaidyanathan ready for review.

Copy link
Collaborator

@ssvaidyanathan ssvaidyanathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssvaidyanathan ssvaidyanathan merged commit e8fcfa5 into apigee:main Jan 22, 2024
2 checks passed
@DinoChiesa DinoChiesa deleted the am-hygiene branch January 24, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants