-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Target Server Validator #698
Conversation
/gcbrun |
I suspect solidarity exclusion is not working because it is not yet |
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: 733a807 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete review, but publishing comments for now...
tools/target-server-validator/apiproxy/resources/java/edge-custom-policy-java-hello.jar
Outdated
Show resolved
Hide resolved
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: 143d27d |
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: 4590268 |
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: a56f446 |
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: 7b9526f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: 2d9387a |
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: 8efa176 |
The two warnings from in-solidarity checks will be supressed when this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tools/target-server-validator/apiproxy/target_server_validator.xml
Outdated
Show resolved
Hide resolved
api_env=$APIGEE_X_ENV | ||
api_name=target_server_validator | ||
api_force_redeploy=true | ||
vhost_domain_name=$APIGEE_X_HOSTNAME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update property name to reflect recent change
Description
The objective of this tool to validate targets in Target Servers & Apigee API Proxy Bundles exported from Apigee OPDK/X/Hybrid.
Validation is done by deploying a sample proxy which check if HOST & PORT is open from Apigee OPDK/X/Hybrid.
Housekeeping
(please check all that apply [x], do not edit the text)
Full Repo Validation Required
(please check all that apply [x], do not edit the text)
CC: @apigee-devrel-reviewers