Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Target Server Validator #698

Merged
merged 15 commits into from
Sep 7, 2023
Merged

Conversation

anaik91
Copy link
Contributor

@anaik91 anaik91 commented Aug 29, 2023

Description

The objective of this tool to validate targets in Target Servers & Apigee API Proxy Bundles exported from Apigee OPDK/X/Hybrid.

Validation is done by deploying a sample proxy which check if HOST & PORT is open from Apigee OPDK/X/Hybrid.

Housekeeping

(please check all that apply [x], do not edit the text)

  • I have run all the tests locally and they all pass.
  • I have followed the relevant style guide for my changes.

Full Repo Validation Required

(please check all that apply [x], do not edit the text)

  • PR requires full pipeline run (Run for changes only by default).

CC: @apigee-devrel-reviewers

@danistrebel
Copy link
Collaborator

/gcbrun

@danistrebel
Copy link
Collaborator

I suspect solidarity exclusion is not working because it is not yet main?

@danistrebel
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/proxy-endpoint-unifier pass 4s
tools/target-server-validator fail 7s
TOTAL PIPELINE pass 11s

View details in Cloud Build (permission required)

Commit version: 733a807

Copy link
Collaborator

@OmidTahouri OmidTahouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete review, but publishing comments for now...

.github/in-solidarity.yml Outdated Show resolved Hide resolved
.github/workflows/devrel-static-checks.yml Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
tools/proxy-endpoint-unifier/main.py Show resolved Hide resolved
tools/target-server-validator/README.md Outdated Show resolved Hide resolved
tools/target-server-validator/README.md Show resolved Hide resolved
tools/target-server-validator/README.md Outdated Show resolved Hide resolved
tools/target-server-validator/README.md Outdated Show resolved Hide resolved
tools/target-server-validator/README.md Outdated Show resolved Hide resolved
tools/target-server-validator/README.md Outdated Show resolved Hide resolved
@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/proxy-endpoint-unifier pass 5s
tools/target-server-validator pass 71s
TOTAL PIPELINE pass 76s

View details in Cloud Build (permission required)

Commit version: 143d27d

@danistrebel
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/proxy-endpoint-unifier pass 5s
tools/target-server-validator pass 93s
TOTAL PIPELINE pass 98s

View details in Cloud Build (permission required)

Commit version: 4590268

.gitignore Outdated Show resolved Hide resolved
@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/pipeline-runner pass 0s
tools/proxy-endpoint-unifier pass 5s
tools/target-server-validator pass 81s
TOTAL PIPELINE pass 86s

View details in Cloud Build (permission required)

Commit version: a56f446

@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/proxy-endpoint-unifier pass 4s
tools/target-server-validator pass 97s
TOTAL PIPELINE pass 101s

View details in Cloud Build (permission required)

Commit version: 7b9526f

Copy link
Collaborator

@OmidTahouri OmidTahouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP

CODEOWNERS Show resolved Hide resolved
tools/target-server-validator/README.md Outdated Show resolved Hide resolved
tools/target-server-validator/README.md Show resolved Hide resolved
tools/target-server-validator/README.md Outdated Show resolved Hide resolved
tools/target-server-validator/README.md Outdated Show resolved Hide resolved
tools/target-server-validator/input.properties Outdated Show resolved Hide resolved
tools/target-server-validator/input.properties Outdated Show resolved Hide resolved
tools/target-server-validator/README.md Outdated Show resolved Hide resolved
tools/target-server-validator/README.md Outdated Show resolved Hide resolved
tools/target-server-validator/main.py Outdated Show resolved Hide resolved
@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/proxy-endpoint-unifier pass 5s
tools/target-server-validator fail 101s
TOTAL PIPELINE pass 106s

View details in Cloud Build (permission required)

Commit version: 2d9387a

@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/proxy-endpoint-unifier pass 5s
tools/target-server-validator pass 83s
TOTAL PIPELINE pass 88s

View details in Cloud Build (permission required)

Commit version: 8efa176

@OmidTahouri
Copy link
Collaborator

The two warnings from in-solidarity checks will be supressed when this PR is merged.

Copy link
Collaborator

@OmidTahouri OmidTahouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/in-solidarity.yml Outdated Show resolved Hide resolved
api_env=$APIGEE_X_ENV
api_name=target_server_validator
api_force_redeploy=true
vhost_domain_name=$APIGEE_X_HOSTNAME
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update property name to reflect recent change

tools/target-server-validator/utilities.py Outdated Show resolved Hide resolved
tools/target-server-validator/utilities.py Outdated Show resolved Hide resolved
@OmidTahouri OmidTahouri merged commit 9a31641 into apigee:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants