Merge pull request #144 from gaonkar18y/for308-add-quota-logging

For308 add quota logging

.travis.yml

@@ -1,6 +1,5 @@
 language: node_js
 node_js:
-- '6.14'
 - '8'
 - '10'
 - '12'

package.json

@@ -27,8 +27,8 @@
     "toobusy-js": "^0.5.1",
     "volos-analytics-apigee": "^0.4.0",
     "volos-cache-memory": "^0.10.0",
-    "volos-quota-apigee": "^0.13.3",
-    "volos-quota-common": "^0.11.7",
+    "volos-quota-apigee": "^0.13.4",
+    "volos-quota-common": "^0.11.8",
     "volos-quota-memory": "^0.11.0",
     "volos-spikearrest-memory": "^0.10.0",
     "xml2js": "^0.4.17"

quota/index.js

@@ -6,12 +6,21 @@
 
 var async = require('async');
 var Quota = require('volos-quota-apigee');
-var debug = require('debug')('gateway:quota');
+var debugTerminal = require('debug')('gateway:quota');
 var url = require('url');
+const util = require('util');
 
 
-module.exports.init = function(config /*, logger, stats */) {
+module.exports.init = function(config, logger /*, stats */) {
 
+    const debug = (...data) => {
+        const formatedData = util.format(...data);
+        logger.debug('quota : '+formatedData);
+        debugTerminal(formatedData);
+    }
+
+    debug('quota plugin init called with config: %j', config)
+
     const { product_to_proxy, proxies } = config;
     const prodsObj = {};
     var quotas = {}; // productName -> connectMiddleware
@@ -33,7 +42,7 @@ module.exports.init = function(config /*, logger, stats */) {
         var product = config[productName];
         if (!product.uri && !product.key && !product.secret && !product.allow && !product.interval || product.interval === "null") {
             // skip non-quota config
-            debug('Quota not configured on the API product, skipping. This message is safe to ignore');
+            debug('Quota not configured on the API product: %s, skipping. This message is safe to ignore',productName);
             return;
         }
 
@@ -64,6 +73,7 @@ module.exports.init = function(config /*, logger, stats */) {
         prodsObj[productName] = prodObj;
 
         config[productName].request = config.request;
+        config[productName]['debug'] = debug;
         var quota = Quota.create(config[productName]);
         quotas[productName] = quota.connectMiddleware().apply(options);
         //
@@ -77,7 +87,7 @@ module.exports.init = function(config /*, logger, stats */) {
             return next();
         }
 
-        debug('quota checking products', req.token.api_product_list);
+        debug('New request, quota checking products', req.token.api_product_list);
 
         req.originalUrl = req.originalUrl || req.url; // emulate connect
 

test/microgateway-core.js

@@ -2,6 +2,8 @@
 /* simulating the objects of microgateway-core to avoid run time errors in travis. */
 module.exports = {
     logger: {
+        debug: function (obj, msg) { },
+        trace: function (obj, msg) { },
         info: function (obj, msg) { },
         warn: function (obj, msg) { },
         error: function (obj, msg) {},