Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with reading config files using --config #1230

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

timburks
Copy link
Contributor

@timburks timburks commented Oct 12, 2023

Fixes #1228.

@timburks timburks force-pushed the config-file-reading branch from 9400518 to 8499171 Compare October 12, 2023 15:57
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1230 (26d381e) into main (be22021) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1230      +/-   ##
==========================================
+ Coverage   71.96%   71.98%   +0.02%     
==========================================
  Files         146      146              
  Lines       12241    12241              
==========================================
+ Hits         8809     8812       +3     
+ Misses       2749     2747       -2     
+ Partials      683      682       -1     
Files Coverage Δ
pkg/config/config.go 59.74% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@timburks timburks force-pushed the config-file-reading branch from 8499171 to 09aeea2 Compare October 12, 2023 16:59
@timburks timburks requested a review from theganyo October 12, 2023 17:22
@timburks timburks merged commit f805290 into apigee:main Oct 12, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Registry tool: --config option fails to accept file name arguments
2 participants