New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configurable keyrings creation in Apigee X core module #126

Merged

danistrebel merged 1 commit into apigee:main from danistrebel:feature/external-keyring

Jun 15, 2023

Collaborator

danistrebel commented Jun 14, 2023

What's changed, or what was fixed?

Made Key rings configurable to allow re-use of existing ones. See Re-use of key rings #112

Fixes: #112

I have run all the tests locally and they all pass.
I have followed the relevant style guide for my changes.

danistrebel requested a review from g-greatdevaks as a code owner

June 14, 2023 18:53


          feat: configurable keyrings creation in Apigee X core module

d70b66d

danistrebel force-pushed the feature/external-keyring branch from 2a295f2 to d70b66d Compare

June 15, 2023 05:30

g-greatdevaks approved these changes

View reviewed changes

Collaborator

g-greatdevaks left a comment

LGTM.

danistrebel merged commit 0b6d46b into apigee:main

danistrebel deleted the feature/external-keyring branch

June 15, 2023 16:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet