allow setting a ClassLoader Supplier #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying a ClassLoader Supplier instead of just a ClassLoader instance gives more flexibility to the embedder by allowing the embedder to choose if classes loaded by multiple innovations of loadJars are isolated from each-other.
|
please also back-port this patch to 0.8.5 and 0.8.6 |
|
I pushed 0.8.5.1 to Maven Central this morning, and it should show up there pretty soon. Can you try it out? Assuming it works I'll also do 0.8.6.1 if you also need that. |
|
0.8.5.1 works fine. Please also apply this change to 0.8.6 and publish - we will need it sooner or later. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying a ClassLoader Supplier instead of just a ClassLoader
instance gives more flexibility to the embedder by allowing the
embedder to choose if classes loaded by multiple innovations of
loadJars are isolated from each-other.