Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API rate limiting to the OAS #91

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Add API rate limiting to the OAS #91

merged 1 commit into from
Apr 18, 2024

Conversation

bot-api-video
Copy link
Contributor

@bot-api-video bot-api-video commented Apr 11, 2024 •
edited
Loading

⚠️ This PR should not be merged before API rate limiting is released ⚠️

Changes are for this Asana task.

Docs drafts are here.

Summary

  • added the 429 - Too many requests error response schema and example to every endpoint except /auth
  • added the following response headers to the 200 response of GET /videos as a test:
    • X-RateLimit-Limit
    • X-RateLimit-Remaining
    • X-RateLimit-Retry-After

⚠️ This PR should not be merged before API rate limiting is released ⚠️

Created by @szekelyzol via apivideo/api.video-api-client-generator#373

@bot-api-video bot-api-video added the documentation Improvements or additions to documentation label Apr 11, 2024
@bot-api-video bot-api-video mentioned this pull request Apr 11, 2024
Merged
@bot-api-video bot-api-video force-pushed the api-rate-limiting-oas branch from 9391f7d to 84ca590 Compare April 16, 2024 14:25
@bot-api-video bot-api-video merged commit 301b28c into main Apr 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bot-api-video @szekelyzol