Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #180] Allow for root-level arrays to be querystring-ed in Modem.prototype.buildQuerystring #181

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Fixes #180] Allow for root-level arrays to be querystring-ed in Modem.prototype.buildQuerystring #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8af381e
Allow for root-level arrays to be querystring-ed in Modem.prototype.b…
Clovel Jan 8, 2025
a9f0586
Updated unit tests for Modem.prototype.buildQuerystring function
Clovel Jan 8, 2025
d5407c3
Removed deprecated warning comment from Modem.prototype.buildQuerystring
Clovel Jan 8, 2025
c1cc6b8
Updated package-lock.json
Clovel Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions lib/modem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,13 +529,11 @@ Modem.prototype.followProgress = function (streama, onFinished, onProgress) {
Modem.prototype.buildQuerystring = function (opts) {
var clone = {};

// serialize map and array values as JSON strings, else querystring truncates.
// 't' and 'extrahosts' can be arrays but need special treatment so that they're
// passed as multiple qs parameters instead of JSON values.
Object.keys(opts).map(function (key, i) {
if (opts[key]
&& typeof opts[key] === 'object'
&& !['t', 'extrahosts'].includes(key)
if (
opts[key] &&
typeof opts[key] === 'object' &&
!Array.isArray(opts[key])
) {
clone[key] = JSON.stringify(opts[key]);
} else {
Expand Down
Loading
Loading