Fix inconsistent behaviour

The modified methods are supposed to return a Promise if callback is undefined
apocas · Mar 13, 2017 · 4c27023 · 4c27023
1 parent 1c65e2d
commit 4c27023
Show file tree

Hide file tree

Showing 10 changed files with 0 additions and 56 deletions.
diff --git a/lib/container.js b/lib/container.js
@@ -45,12 +45,6 @@ Container.prototype.inspect = function(opts, callback) {
   var self = this;
   var args = util.processArgs(opts, callback);
 
-  if (typeof args.callback !== 'function') {
-    return JSON.stringify({
-      id: this.id
-    });
-  }
-
   var optsf = {
     path: '/containers/' + this.id + '/json?',
     method: 'GET',

diff --git a/lib/exec.js b/lib/exec.js
@@ -101,11 +101,6 @@ Exec.prototype.resize = function(opts, callback) {
  */
 Exec.prototype.inspect = function(callback) {
   var self = this;
-  if (typeof callback !== 'function') {
-    return JSON.stringify({
-      id: this.id
-    });
-  }
 
   var optsf = {
     path: '/exec/' + this.id + '/json',

diff --git a/lib/image.js b/lib/image.js
@@ -17,11 +17,6 @@ var Image = function(modem, name) {
  */
 Image.prototype.inspect = function(callback) {
   var self = this;
-  if (typeof callback !== 'function') {
-    return JSON.stringify({
-      name: this.name
-    });
-  }
 
   var opts = {
     path: '/images/' + this.name + '/json',

diff --git a/lib/network.js b/lib/network.js
@@ -17,11 +17,6 @@ var Network = function(modem, id) {
  */
 Network.prototype.inspect = function(callback) {
   var self = this;
-  if (typeof callback !== 'function') {
-    return JSON.stringify({
-      Id: this.id
-    });
-  }
 
   var opts = {
     path: '/networks/' + this.id,

diff --git a/lib/node.js b/lib/node.js
@@ -18,11 +18,6 @@ var Node = function(modem, id) {
  */
 Node.prototype.inspect = function(callback) {
   var self = this;
-  if (typeof callback !== 'function') {
-    return JSON.stringify({
-      id: this.id
-    });
-  }
 
   var optsf = {
     path: '/nodes/' + this.id,
@@ -102,11 +97,6 @@ Node.prototype.update = function(opts, callback) {
  */
 Node.prototype.remove = function(callback) {
   var self = this;
-  if (typeof callback !== 'function') {
-    return JSON.stringify({
-      id: this.id
-    });
-  }
 
   var optsf = {
     path: '/nodes/' + this.id,

diff --git a/lib/plugin.js b/lib/plugin.js
@@ -18,11 +18,6 @@ var Plugin = function(modem, name, remote) {
  */
 Plugin.prototype.inspect = function(callback) {
   var self = this;
-  if (typeof callback !== 'function') {
-    return JSON.stringify({
-      name: this.name
-    });
-  }
 
   var optsf = {
     path: '/plugins/' + this.name,

diff --git a/lib/secret.js b/lib/secret.js
@@ -17,11 +17,6 @@ var Secret = function(modem, id) {
  */
 Secret.prototype.inspect = function(callback) {
   var self = this;
-  if (typeof callback !== 'function') {
-    return JSON.stringify({
-      id: this.id
-    });
-  }
 
   var optsf = {
     path: '/secrets/' + this.id,

diff --git a/lib/service.js b/lib/service.js
@@ -18,11 +18,6 @@ var Service = function(modem, id) {
  */
 Service.prototype.inspect = function(callback) {
   var self = this;
-  if (typeof callback !== 'function') {
-    return JSON.stringify({
-      id: this.id
-    });
-  }
 
   var optsf = {
     path: '/services/' + this.id,

diff --git a/lib/task.js b/lib/task.js
@@ -18,11 +18,6 @@ var Task = function(modem, id) {
  */
 Task.prototype.inspect = function(callback) {
   var self = this;
-  if (typeof callback !== 'function') {
-    return JSON.stringify({
-      id: this.id
-    });
-  }
 
   var optsf = {
     path: '/tasks/' + this.id,

diff --git a/lib/volume.js b/lib/volume.js
@@ -17,11 +17,6 @@ var Volume = function(modem, name) {
  */
 Volume.prototype.inspect = function(callback) {
   var self = this;
-  if (typeof callback !== 'function') {
-    return JSON.stringify({
-      name: this.name
-    });
-  }
 
   var optsf = {
     path: '/volumes/' + this.name,