fix calling Service#update with only one parameter

when calling Service#update with only one parameter, then that parameter should be options not authconfig, and the method should return a Promise
apocas · May 14, 2017 · 4d50ed3 · 4d50ed3
1 parent f193e89
commit 4d50ed3
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/lib/service.js b/lib/service.js
@@ -88,10 +88,16 @@ Service.prototype.remove = function(callback) {
  */
 Service.prototype.update = function(auth, opts, callback) {
   var self = this;
-  if (!callback && typeof opts === 'function') {
-    callback = opts;
-    opts = auth;
-    auth = opts.authconfig || undefined;
+  if (!callback) {
+    var t = typeof opts;
+    if(t === 'function'){
+      callback = opts;
+      opts = auth;
+      auth = opts.authconfig || undefined;
+    } else if (t === 'undefined'){
+      opts = auth;
+      auth = opts.authconfig || undefined;
+    }
   }
 
   var optsf = {