feat(types): turn LocalForageWrapper
into a generic class
#528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalForageWrapper
is currently typed asstring | object | null,
but it solely depends on whether we serialize or not.Also,
localForage
(and IndexedDB) supports storing more thanstring
orobject
, it supports the following JS objects:I didn't want to introduce a breaking change by changing the type, so instead, I turned
LocalForageWrapper
into a generic class expecting a type for LocalForage and defaulting tostring | object | null
(current value).It means that if you're storing binary data in IndexedDB, you can provide the type as such:
LocalForageWrapper<Uint8Array>
.