wrap injectScript call in try..catch, offer extension builds as PR artifacts
#1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#876 Bundle Size — 1.51MiB (0%).bd71905(current) vs a413e0b main#871(baseline) Warning Bundle contains 13 duplicate packages – View duplicate packages Bundle metrics
|
| Current #876 |
Baseline #871 |
|
|---|---|---|
 Initial JS |
1.47MiB |
1.47MiB |
| Initial CSS |
0B |
0B |
| Cache Invalidation |
0% |
0% |
| Chunks |
5 |
5 |
| Assets |
12 |
12 |
| Modules |
1218 |
1218 |
| Duplicate Modules |
45 |
45 |
| Duplicate Code |
3.12% |
3.12% |
| Packages |
183 |
183 |
| Duplicate Packages |
10 |
10 |
Bundle size by type no changes
| Current #876 |
Baseline #871 |
|
|---|---|---|
| JS |
1.47MiB |
1.47MiB |
| IMG |
35.85KiB |
35.85KiB |
| HTML |
857B |
857B |
| Other |
757B |
757B |
Bundle analysis report Branch pr/try-injection Project dashboard
Generated by RelativeCI Documentation Report issue
phryneas
commented
Sep 16, 2024
Comment on lines
+53
to
+60
| try { | ||
| injectScript(browser.runtime.getURL("hook.js")); | ||
| } catch (e) { | ||
| console.warn( | ||
| "Error occured while trying to initialize Apollo Client Devtools:", | ||
| e | ||
| ); | ||
| } |
There was a problem hiding this comment.
This doesn't work, as the error is triggered delayed when the script evaluates, not when it is inserted in DOM.
Also, listening for a securitypolicyviolation event allows me to read the details of the violation, but not to prevent it from crashing the whole page. I'm a bit out of ideas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might resolve #1519.
Also adding a "download build extension" comment to future PRs with this, which would make it easier to get quick user feedback.