TanStack Start: adjust to new streaming method post 1.99 #422

phryneas · 2025-02-03T14:56:54Z

No description provided.

changeset-bot · 2025-02-03T14:56:58Z

⚠️ No Changeset found

Latest commit: 3c98038

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-02-03T14:59:19Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
apollo__client-integration-react-router	✅ Ready (Inspect)	Visit Preview	Feb 5, 2025 2:12pm
apollo__client-integration-tanstack-start	🛑 Canceled (Inspect)		Feb 5, 2025 2:12pm

pkg-pr-new · 2025-02-03T14:59:41Z

npm i https://pkg.pr.new/apollographql/apollo-client-nextjs/@apollo/client-integration-react-router@422

npm i https://pkg.pr.new/apollographql/apollo-client-nextjs/@apollo/client-integration-tanstack-start@422

npm i https://pkg.pr.new/apollographql/apollo-client-nextjs/@apollo/client-react-streaming@422

npm i https://pkg.pr.new/apollographql/apollo-client-nextjs/@apollo/experimental-nextjs-app-support@422

commit: 55624a8

relativeci · 2025-02-03T15:02:18Z

#441 Bundle Size — 1.33MiB (+6.75%).

55624a8(current) vs 5293db1 main#409(baseline)

Warning

Bundle contains 1 duplicate package – View duplicate packages

Warning

Bundle introduced one new package: process – View changed packages

Bundle metrics

8 changes

1 regression

2 improvements

	Current #441	Baseline #409
Initial JS	`1.05MiB`(`+5.68%`)	`1016.91KiB`
Initial CSS	`70B`	`70B`
Cache Invalidation	`81.12%`	`0.08%`
Chunks	`37`(`+8.82%`)	`34`
Assets	`63`(`+6.78%`)	`59`
Modules	`676`(`+6.29%`)	`636`
Duplicate Modules	`98`(`-7.55%`)	`106`
Duplicate Code	`4.33%`(`-7.87%`)	`4.7%`
Packages	`25`(`-3.85%`)	`26`
Duplicate Packages	`1`	`1`

Bundle size by type

3 changes

3 regressions

	Current #441	Baseline #409
JS	`1.32MiB` (`+100%`)	`undefined`
Other	`10.27KiB` (`+100%`)	`undefined`
CSS	`70B` (`+100%`)	`undefined`

Bundle analysis report Branch pr/adjust-tanstack-streaming Project dashboard

^{Generated by RelativeCI Documentation Report issue}

…reaming

phryneas · 2025-02-04T15:05:32Z

This works now, but I'm waiting for a small last change on the TanStack side so we can use hydrate instead of the useRouterState workaround.

phryneas · 2025-02-05T13:26:22Z

TanStack/router@a4ae8ec has landed in 1.99.4 so this should be good to go if it successfully deploys.

phryneas · 2025-02-05T13:58:12Z

package.json

-    "@tanstack/start": "patch:@tanstack/start@npm%3A1.97.3#~/.yarn/patches/@tanstack-start-npm-1.97.3-da273c2822.patch",
+    "@tanstack/start": "1.99.6",
+    "@tanstack/react-router": "1.99.6",
+    "@tanstack/start-router-manifest": "1.99.0",


This is currently pinned to 1.99.0 to prevent a HMR problem on the TanStack side

phryneas · 2025-02-05T14:00:26Z

packages/tanstack-start/src/ApolloProvider.tsx

-      // so "loading" is kicked off before the respecitve component is rendered
-      consumeBackPressure();
+      if (onQueryEvent) {
+        registerLateInitializingQueue("__APOLLO_EVENTS__", onQueryEvent);


Yay for reusing tools we already have :)

phryneas · 2025-02-05T14:13:26Z

Yup, this seems to work nicely. Ready for review!

phryneas added 2 commits January 27, 2025 16:47

adjust to new streaming method

2a6e58a

wip state sharing

027a315

vercel bot deployed to Preview – apollo__client-integration-react-router February 3, 2025 14:59 View deployment

vercel bot deployed to Preview – apollo__experimental-nextjs-app-support February 3, 2025 15:02 View deployment

vercel bot deployed to Preview – apollo__client-integration-tanstack-start February 3, 2025 15:05 View deployment

phryneas added 4 commits February 3, 2025 18:24

add constraint checks to repo

c623ffd

Merge remote-tracking branch 'origin/next' into pr/adjust-tanstack-st…

df7c338

…reaming

move rehydration into selector in ApolloProvider

04a42f7

remove log

0754d00

vercel bot deployed to Preview – apollo__client-integration-tanstack-start February 4, 2025 10:29 View deployment

vercel bot deployed to Preview – apollo__experimental-nextjs-app-support February 4, 2025 10:32 View deployment

vercel bot deployed to Preview – apollo__client-integration-react-router February 4, 2025 10:34 View deployment

adjust dependencies

8126190

phryneas changed the title ~~adjust to new streaming method~~ TanStack Start: adjust to new streaming method post 1.99 Feb 4, 2025

phryneas added 2 commits February 4, 2025 11:40

also publish PR builds

b250da4

add to README

6b1b02a

vercel bot deployed to Preview – apollo__client-integration-tanstack-start February 4, 2025 10:44 View deployment

vercel bot deployed to Preview – apollo__experimental-nextjs-app-support February 4, 2025 10:47 View deployment

vercel bot deployed to Preview – apollo__client-integration-react-router February 4, 2025 10:49 View deployment

move loaderData hydration logic into hydrate

f21dbbc

vercel bot deployed to Preview – apollo__client-integration-tanstack-start February 5, 2025 13:27 View deployment

vercel bot deployed to Preview – apollo__client-integration-react-router February 5, 2025 13:30 View deployment

vercel bot deployed to Preview – apollo__experimental-nextjs-app-support February 5, 2025 13:32 View deployment

fix README

edcee1f

vercel bot deployed to Preview – apollo__client-integration-react-router February 5, 2025 13:59 View deployment

phryneas added 3 commits February 5, 2025 14:59

move streamedInit closer to ensureInitialized

3c7135c

simplify code

3c98038

remove unneccesary return statement

55624a8

phryneas commented Feb 5, 2025

View reviewed changes

vercel bot deployed to Preview – apollo__client-integration-react-router February 5, 2025 14:09 View deployment

vercel bot deployed to Preview – apollo__client-integration-tanstack-start February 5, 2025 14:12 View deployment

phryneas marked this pull request as ready for review February 5, 2025 14:13

phryneas requested a review from a team as a code owner February 5, 2025 14:13

vercel bot deployed to Preview – apollo__experimental-nextjs-app-support February 5, 2025 14:15 View deployment

jerelmiller approved these changes Feb 5, 2025

View reviewed changes

phryneas merged commit c01a77b into next Feb 6, 2025
25 checks passed

phryneas deleted the pr/adjust-tanstack-streaming branch February 6, 2025 08:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TanStack Start: adjust to new streaming method post 1.99 #422

TanStack Start: adjust to new streaming method post 1.99 #422

phryneas commented Feb 3, 2025

changeset-bot bot commented Feb 3, 2025 •

edited

Loading

vercel bot commented Feb 3, 2025 •

edited

Loading

pkg-pr-new bot commented Feb 3, 2025 •

edited

Loading

relativeci bot commented Feb 3, 2025 •

edited

Loading

phryneas commented Feb 4, 2025

phryneas commented Feb 5, 2025

phryneas Feb 5, 2025

phryneas Feb 5, 2025

phryneas commented Feb 5, 2025

TanStack Start: adjust to new streaming method post 1.99 #422

TanStack Start: adjust to new streaming method post 1.99 #422

Conversation

phryneas commented Feb 3, 2025

changeset-bot bot commented Feb 3, 2025 • edited Loading

⚠️ No Changeset found

vercel bot commented Feb 3, 2025 • edited Loading

pkg-pr-new bot commented Feb 3, 2025 • edited Loading

relativeci bot commented Feb 3, 2025 • edited Loading

#441 Bundle Size — 1.33MiB (+6.75%).

phryneas commented Feb 4, 2025

phryneas commented Feb 5, 2025

phryneas Feb 5, 2025

Choose a reason for hiding this comment

phryneas Feb 5, 2025

Choose a reason for hiding this comment

phryneas commented Feb 5, 2025

changeset-bot bot commented Feb 3, 2025 •

edited

Loading

vercel bot commented Feb 3, 2025 •

edited

Loading

pkg-pr-new bot commented Feb 3, 2025 •

edited

Loading

relativeci bot commented Feb 3, 2025 •

edited

Loading