Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ApolloPagination] Update README #109

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

Iron-Ham
Copy link
Contributor

Update the README to let folks know that this package may be subject to breaking changes.

Copy link
Member

@BobaFetters BobaFetters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BobaFetters BobaFetters requested a review from a team as a code owner November 15, 2023 18:13
@calvincestari
Copy link
Member

@Iron-Ham did you want to make anymore changes to this PR or can it be merged?

@Iron-Ham
Copy link
Contributor Author

Iron-Ham commented Dec 4, 2023

@calvincestari I think this is good to merge! When we get a bit closer to a proper release, I'll look into a more comprehensive README.

@calvincestari
Copy link
Member

Looks like the gitleaks check is holding this up but I'm going to go ahead and merge it anyways.

@calvincestari calvincestari merged commit 6e5b864 into apollographql:main Dec 4, 2023
12 checks passed
BobaFetters pushed a commit that referenced this pull request Dec 4, 2023
BobaFetters pushed a commit to apollographql/apollo-ios-pagination that referenced this pull request Dec 4, 2023
BobaFetters pushed a commit that referenced this pull request Dec 4, 2023
71f74166 [ApolloPagination] Update README (#109)

git-subtree-dir: apollo-ios-pagination
git-subtree-split: 71f741663b0eb993a08c640c8271b0d853881d80
BobaFetters pushed a commit that referenced this pull request Dec 4, 2023
…ADME

git-subtree-dir: apollo-ios-pagination
git-subtree-mainline: 22e0c5d
git-subtree-split: 71f741663b0eb993a08c640c8271b0d853881d80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants