Codegen Vaildation - Handle Non Fatal Errors #202
Merged
+2,093
−1,563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cops orb version git-subtree-dir: apollo-ios-codegen git-subtree-mainline: e64dae8 git-subtree-split: 44b718a9a30d97681b9d550eb1ceedc2cc5d7c30
44b718a9 chore(deps): Update CircleCI secops orb version (#197) git-subtree-dir: apollo-ios-codegen git-subtree-split: 44b718a9a30d97681b9d550eb1ceedc2cc5d7c30
70a6b37a chore(deps): Update CircleCI secops orb version (#197) git-subtree-dir: apollo-ios-pagination git-subtree-split: 70a6b37a86f420a863d345163dfaf2c4db257ff1
… secops orb version git-subtree-dir: apollo-ios-pagination git-subtree-mainline: cbc6140 git-subtree-split: 70a6b37a86f420a863d345163dfaf2c4db257ff1
…erers to use errorRecorder
d8ac9b9e chore(deps): Update to graphql-js 17.0.0-alpha.3 (#194) git-subtree-dir: apollo-ios-codegen git-subtree-split: d8ac9b9eeeefb756417ac62856cf24bcbd74b0b8
…js 17.0.0-alpha.3 git-subtree-dir: apollo-ios-codegen git-subtree-mainline: a7870b3 git-subtree-split: d8ac9b9eeeefb756417ac62856cf24bcbd74b0b8
calvincestari
approved these changes
Dec 18, 2023
...tions/CodegenXCFramework/CodegenXCFramework/MyAPI/Fragments/WarmBloodedDetails.graphql.swift
Show resolved
Hide resolved
...amework/CodegenXCFramework/MyAPI/Operations/Queries/AllAnimalsIncludeSkipQuery.graphql.swift
Show resolved
Hide resolved
apollo-ios-codegen/Sources/ApolloCodegenLib/ApolloCodegen+Errors.swift
Outdated
Show resolved
Hide resolved
apollo-ios-codegen/Sources/ApolloCodegenLib/ApolloCodegen+Errors.swift
Outdated
Show resolved
Hide resolved
apollo-ios-codegen/Sources/ApolloCodegenLib/Templates/TemplateRenderer.swift
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| } | ||
|
|
||
| // MARK: - Helper Extensions | ||
|
|
||
| fileprivate extension IR.ComputedSelectionSet { | ||
| extension IR.ComputedSelectionSet { |
There was a problem hiding this comment.
This is a style question but why not leave the visibility annotation on the extension vs. having to repeat it for each property and function?
…rs.swift Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com>
…rs.swift Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com>
…Renderer.swift Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on top of #152. It should not be merged until after that PR is merged.
Adds
NonFatalErrorserror type andNonFatalErrorstruct to collect and report non fatal errors that occur during the code generation.Instead of being thrown when encountered, these errors are returned from the
TemplateRendererandFileGeneratorobjects to allow code generation execution to continue. After codegen is finished, any errors returned here are thrown fromApolloCodegen.build()before exiting.This also includes changes to
SelectionSetTemplateto implement the checking for type conflict errors incrementally asComputedSelectionSets are built, rather than requiring allComputedSelectionSets to be pre-built and retained for the entirety of execution.