[Codegen] Fix retain cycle between Entity and TypeInfo #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
AnthonyMDev
changed the base branch from
main
to
codegen-vaildation-refactor
|
@pm-dev This one will also help reduce the memory allocation during your project's huge code generation step. The time complexity of fragment field merging means that your codegen will probably still take way too long without disabling that. But the memory issues should be noticeably improved. |
calvincestari
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a retain cycle that was causing memory leaks. This was manually tested to verify that TypeInfo and Entity objects are now properly released when their operations are complete.