Skip to content

Commit

Permalink
downgrade protobuf dependency to v3 (#428)
Browse files Browse the repository at this point in the history
We are using protobuf to generate `ftv1` tracing information. Protobuf
v4 made a backwards incompatible change that prevents using those
messages with v3 services. Since there are a lot of existing libraries
(including `grpc-java`) that still depend on the v3 format and generated
protobuf v3 message can be used for both v3 and v4 services we'll be
reverting to v3 as well.

See:
grpc/grpc-java#11015 (comment)

Resolves: #421
  • Loading branch information
dariuszkuc authored Jan 9, 2025
1 parent 509b978 commit 1c56ca0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ version = 3.0-SNAPSHOT
# dependencies
annotationsVersion = 24.1.0
graphQLJavaVersion = 22.3
protobufVersion = 4.27.1
# generated proto v3 messages can be used with v3 and v4
protobufVersion = 3.25.5
slf4jVersion = 2.0.16
springBootVersion = 3.3.6

Expand Down

0 comments on commit 1c56ca0

Please sign in to comment.