Skip to content

Commit

Permalink
update warning message
Browse files Browse the repository at this point in the history
  • Loading branch information
haroun committed Nov 12, 2024
1 parent 15aa5ad commit 115b2ee
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ did not actually use any noncompliant cookie names or values, so there was no vu
* It's possible now to target the HMR build when registering via `template.append` and `template.prepend`. Use `when: 'hmr:public'` or `when: 'hmr:apos'` that will be evaluated against the current asset `options.hmr` configuration.
* Adds asset module option `options.modulePreloadPolyfill` (default `true`) to allow disabling the polyfill preload for e.g. external front-ends.
* Adds `bundleMarkup` to the data sent to the external front-end, containing all markup for injecting Apostrophe UI in the front-end.
* Warns users when two page types shares the same field name, but has a different type. This may cause errors or other problems when an editor switches page types.

### Changes

Expand Down
2 changes: 1 addition & 1 deletion modules/@apostrophecms/page/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,7 @@ module.exports = {
for (const right of self.typeChoices) {
const diff = compareSchema(left, right);
if (diff.size) {
self.apos.util.warnDev(`The page type "${left.name}" has a conflict with "${right.name}" (${formatDiff(diff)})`);
self.apos.util.warnDev(`The page type "${left.name}" has a conflict with "${right.name}" (${formatDiff(diff)}). This may cause errors or other problems when an editor switches page types.`);
}
}
}
Expand Down

0 comments on commit 115b2ee

Please sign in to comment.