Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO-6587: access to fully rendered rich text widgets without giving up all access to other area properties or logging out #4806

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

boutell
Copy link
Member

@boutell boutell commented Nov 18, 2024

Summary

See changelog

What are the specific steps to test this change?

  • npm link into starter-kit-essentials
  • make an inline permalink (not a pasted URL link) to another page, refresh page — it is still recognized as such by the link dialog
  • same for inline images in rich text — still recognized as an existing inline image by the editor on next visit
  • note the incognito view still fully resolves the URLs of linked pages and inline images (desirable behavior, except in the editor)
  • Now, while logged in, use the GET REST API to access the home page at http://localhost:3000/api/v1/@apostrophecms/page/_home
  • Note that inline images and permalinks are not fully resolved (appropriate because we might be editing)
  • Now add ?render-areas=inline
  • Note that each widget now has an additional _rendered property containing fully rendered markup for that widget, including fully resolved inline images and permalinks

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

…p all access to other area properties or logging out
@boutell boutell requested a review from BoDonkey November 18, 2024 20:14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you want to honor/fix the GitHub Action flag here.

Copy link
Contributor

@BoDonkey BoDonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as documented. GitHub flags that could be fixed. 🤷🏻‍♂️

@boutell boutell merged commit 9e98ba9 into main Nov 19, 2024
9 checks passed
@boutell boutell deleted the pro-6587 branch November 19, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants