indicate failure to export functions, rather than return null in top level #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the function export raises an error, indicate that error rather than returning. returning is invalid in the top-level context anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the most meaningful change in this pull request is to indicate failure to export function. this replaces an attempt to return null at the top level, which is invalid.
other changes include making explanations fit within the comment stars, removing stray end-of-line whitespace, and my favorite, standardizing the indent space count. some files had 4, some had 2. i was not able to quickly separate this last change into its own commit, so it's mixed with the others.