Bump deps #3825
clippy
11 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 11 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.79.0 (129f3b996 2024-06-10)
- cargo 1.79.0 (ffa9cf99a 2024-06-03)
- clippy 0.1.79 (129f3b9 2024-06-10)
Annotations
Check warning on line 526 in store/src/local/mutation_index/query.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> store/src/local/mutation_index/query.rs:526:17
|
526 | part.field = part.text.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `part.field.clone_from(&part.text)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 578 in store/src/local/entity_index/mod.rs
github-actions / clippy
usage of a legacy numeric constant
warning: usage of a legacy numeric constant
--> store/src/local/entity_index/mod.rs:578:66
|
578 | let block_offset = result.block_offset.unwrap_or(std::u64::MAX);
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
578 | let block_offset = result.block_offset.unwrap_or(u64::MAX);
| ~~~~~~~~
Check warning on line 133 in store/src/local/entity_index/iterator.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> store/src/local/entity_index/iterator.rs:133:17
|
133 | entity_id = next_id.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `entity_id.clone_from(next_id)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 188 in store/src/local/entity_index/aggregator.rs
github-actions / clippy
usage of a legacy numeric constant
warning: usage of a legacy numeric constant
--> store/src/local/entity_index/aggregator.rs:188:67
|
188 | if current_operation_id > last_operation_id.unwrap_or(std::u64::MIN) {
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `#[warn(clippy::legacy_numeric_constants)]` on by default
help: use the associated constant instead
|
188 | if current_operation_id > last_operation_id.unwrap_or(u64::MIN) {
| ~~~~~~~~
Check warning on line 115 in store/src/local/entity_index/aggregator.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> store/src/local/entity_index/aggregator.rs:115:13
|
115 | entity_id = current_mutation.entity_id.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `entity_id.clone_from(¤t_mutation.entity_id)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
Check warning on line 61 in store/src/local/mutation_index/results.rs
github-actions / clippy
field `remaining` is never read
warning: field `remaining` is never read
--> store/src/local/mutation_index/results.rs:61:9
|
58 | pub struct MutationResults {
| --------------- field in this struct
...
61 | pub remaining: usize,
| ^^^^^^^^^
Check warning on line 285 in store/src/local/entity_index/searcher.rs
github-actions / clippy
field `matched_mutation` is never read
warning: field `matched_mutation` is never read
--> store/src/local/entity_index/searcher.rs:285:9
|
284 | pub struct SearchResult {
| ------------ field in this struct
285 | pub matched_mutation: MutationMetadata,
| ^^^^^^^^^^^^^^^^
Check warning on line 59 in store/src/local/entity_index/aggregator.rs
github-actions / clippy
field `last_block_offset` is never read
warning: field `last_block_offset` is never read
--> store/src/local/entity_index/aggregator.rs:59:9
|
28 | pub struct EntityAggregator {
| ---------------- field in this struct
...
59 | pub last_block_offset: Option<BlockOffset>,
| ^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 162 in chain/src/chain/directory/tracker.rs
github-actions / clippy
field `0` is never read
warning: field `0` is never read
--> chain/src/chain/directory/tracker.rs:162:10
|
162 | Read(Arc<memmap2::Mmap>),
| ---- ^^^^^^^^^^^^^^^^^^
| |
| field in this variant
|
= note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
162 | Read(()),
| ~~
Check warning on line 86 in transport/src/messages.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> transport/src/messages.rs:86:9
|
86 | msg.connection = self.connection.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `msg.connection.clone_from(&self.connection)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
Check warning on line 20 in core/src/sec/keys.rs
github-actions / clippy
field `0` is never read
warning: field `0` is never read
--> core/src/sec/keys.rs:20:15
|
20 | Secp256k1(libp2p_secp256k1::Keypair),
| --------- ^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| field in this variant
|
= note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
20 | Secp256k1(()),
| ~~