Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix possible crash when dismissing the view controller #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,6 @@
Build & Test.xcscheme
sms.xcscheme
xcschememanagement.plist
.DS_Store
ios/sms.xcodeproj/xcuserdata/*.xcuserdatad/xcschemes/Build & Test.xcscheme
/ios/dist
15 changes: 12 additions & 3 deletions ios/Classes/TiSmsModuleAssets.m
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,22 @@
*/
#import "TiSmsModuleAssets.h"

extern NSData * dataWithHexString (NSString * hexString);
extern NSData* filterDataInRange(NSData* thedata, NSRange range);

@implementation TiSmsModuleAssets

- (NSData*) moduleAsset
- (NSData *)moduleAsset
{
return nil;


return nil;
}

- (NSData *)resolveModuleAsset:(NSString *)path
{


return nil;
}

@end
22 changes: 13 additions & 9 deletions ios/Classes/TiSmsSMSDialogProxy.m
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,10 @@ - (MFMessageComposeViewController*)smsDialog
return smsDialog;
}

- (void)dealloc
- (void)_destroy
{
[smsDialog setDelegate:nil];
RELEASE_TO_NIL(smsDialog);
[super dealloc];
[super _destroy];
smsDialog.delegate = nil;
}

#pragma mark Public API's
Expand Down Expand Up @@ -114,13 +113,18 @@ - (void)open:(id)args

- (void)messageComposeViewController:(MFMessageComposeViewController *)composer didFinishWithResult:(MessageComposeResult)result
{
[[TiApp app] hideModalController:composer animated:YES];
RELEASE_TO_NIL(smsDialog);

TiThreadPerformOnMainThread(^{
[[TiApp app] hideModalController:composer animated:YES];
}, YES);

// Release SMS dialog instance
smsDialog.delegate = nil;
smsDialog = nil;

if ([self _hasListeners:@"complete"]) {
[self fireEvent:@"complete" withObject:@{
@"result": NUMINT(result),
@"success": NUMINT(YES)
@"result": @(result),
@"success": @(YES)
}];
}
}
Expand Down
6 changes: 0 additions & 6 deletions ios/assets/README

This file was deleted.

198 changes: 0 additions & 198 deletions ios/build.py

This file was deleted.

1 change: 0 additions & 1 deletion ios/hooks/README

This file was deleted.

35 changes: 0 additions & 35 deletions ios/hooks/add.py

This file was deleted.

19 changes: 0 additions & 19 deletions ios/hooks/install.py

This file was deleted.

34 changes: 0 additions & 34 deletions ios/hooks/remove.py

This file was deleted.

18 changes: 0 additions & 18 deletions ios/hooks/uninstall.py

This file was deleted.

Loading