COLD-370 Add unionpay as an accepted card type #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jira Issue: https://appfolio.atlassian.net/browse/COLD-365 |
KyleG43
force-pushed
the
COLD-365-UnionPay-Spike
branch
3 times, most recently
from
444b230 to
4888106
Compare
KyleG43
commented
Mar 8, 2024
| @@ -33,6 +40,7 @@ const ICONS: { | |||
| 'master-card': 'cc-mastercard', | |||
| discover: 'cc-discover', | |||
| jcb: 'cc-jcb', | |||
| unionpay: 'credit-card', | |||
There was a problem hiding this comment.
I couldn't find a Font Awesome icon for UnionPay, so I used the default credit card icon. We may want to use the discover Icon instead
KyleG43
changed the title
|
Jira Issue: https://appfolio.atlassian.net/browse/COLD-370 |
KyleG43
force-pushed
the
COLD-365-UnionPay-Spike
branch
from
4888106 to
8582543
Compare
|
Released prerelease version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds UnionPay to the list of accepted card types and assigns a Font Awesome icon to it.