Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(SortableColumn): make the sortable prop to SortableColumn more d… #1263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Table/SortableTable.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export interface SortableColumn<T> extends Omit<HeaderProps, 'children' | 'onSor
header?: React.ReactNode;
key: string;
onSort?: (ascending: boolean) => void;
sortable?: boolean;
width?: string;
}

Expand Down
1 change: 1 addition & 0 deletions src/components/Table/SortableTable.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ class SortableTable extends React.Component {
header: PropTypes.node,
key: PropTypes.string,
onSort: PropTypes.func,
sortable: PropTypes.bool,
width: PropTypes.string,
})
).isRequired,
Expand Down
4 changes: 4 additions & 0 deletions src/components/Table/SortableTable.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ export const SortableTableExample = ({ column, ascending, ...args }) => (
key: 'first',
cell: (row) => row.first,
onSort: action('onSort-First'),
sortable: true,
width: '20%',
},
{
Expand All @@ -120,6 +121,7 @@ export const SortableTableExample = ({ column, ascending, ...args }) => (
key: 'last',
cell: (row) => row.last,
onSort: action('onSort-Last'),
sortable: true,
width: '30%',
},
{
Expand All @@ -129,6 +131,7 @@ export const SortableTableExample = ({ column, ascending, ...args }) => (
key: 'dob',
cell: (row) => fecha.format(row.dob, 'MM/DD/YYYY'),
onSort: action('onSort-DOB'),
sortable: true,
width: '15%',
},
{
Expand All @@ -138,6 +141,7 @@ export const SortableTableExample = ({ column, ascending, ...args }) => (
key: 'email',
cell: EmailCell,
onSort: action('onSort-Email'),
sortable: true,
width: '35%',
},
]}
Expand Down
48 changes: 48 additions & 0 deletions src/components/Table/UncontrolledTable.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const DATA = [
last: 'Jones',
email: '[email protected]',
dob: new Date(1968, 6, 15),
estimatedAge: '25-37',
},
{
key: '222',
Expand All @@ -20,6 +21,7 @@ const DATA = [
last: 'Thomas',
email: '[email protected]',
dob: new Date(1972, 7, 17),
estimatedAge: '29-80',
},
{
key: '333',
Expand All @@ -28,6 +30,7 @@ const DATA = [
last: 'Douglas',
email: '[email protected]',
dob: new Date(1982, 4, 1),
estimatedAge: '31-85',
},
{
key: '444',
Expand All @@ -36,6 +39,7 @@ const DATA = [
last: 'Rhodes',
email: '[email protected]',
dob: new Date(1968, 8, 14),
estimatedAge: '40-69',
},
{
key: '555',
Expand All @@ -44,6 +48,7 @@ const DATA = [
last: 'Mendoza',
email: '[email protected]',
dob: new Date(1964, 1, 1),
estimatedAge: '45-91',
},
{
key: '666',
Expand All @@ -52,6 +57,7 @@ const DATA = [
last: 'Montgomery',
email: '[email protected]',
dob: new Date(1960, 6, 4),
estimatedAge: '50-99',
},
{
key: '777',
Expand All @@ -60,6 +66,7 @@ const DATA = [
last: 'Thomas',
email: '[email protected]',
dob: new Date(1973, 0, 11),
estimatedAge: '1-47',
},
{
key: '888',
Expand All @@ -68,6 +75,7 @@ const DATA = [
last: 'Elliott',
email: '[email protected]',
dob: new Date(1954, 7, 17),
estimatedAge: '2-16',
},
{
key: '999',
Expand All @@ -77,6 +85,7 @@ const DATA = [
email: '[email protected]',
dob: new Date(1961, 8, 19),
disabled: true,
estimatedAge: '4-88',
},
{
key: '000',
Expand All @@ -86,6 +95,7 @@ const DATA = [
email: '[email protected]',
dob: new Date(1984, 6, 1),
disabled: true,
estimatedAge: '70-72',
},
];

Expand Down Expand Up @@ -309,3 +319,41 @@ export const CustomExpandColumn = (args) => (
/>
</div>
);

export const UnsortableColumn = (args) => (
<div>
<UncontrolledTable
columns={[
{
header: 'First',
key: 'first',
cell: (row) => row.first,
width: '20%',
},
{
header: 'Last',
key: 'last',
cell: (row) => row.last,
width: '30%',
},
{
header: 'Estimated Age',
key: 'estimatedAge',
cell: (row) => row.estimatedAge,
width: '15%',
sortable: false,
},
{
header: 'Email',
key: 'email',
cell: EmailCell,
width: '35%',
},
]}
rows={DATA}
rowExpanded={FullName}
sort={{ column: 'last', ascending: true }}
{...args}
/>
</div>
);
Loading