Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: keep error handling for the future possible usage #921

Merged
merged 1 commit into from
Jul 21, 2024
Merged

chore: keep error handling for the future possible usage #921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions WebDriverAgentLib/Utilities/FBW3CActionsSynthesizer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,14 @@ @implementation FBW3CActionsSynthesizer
});

NSArray<NSDictionary<NSString *, id> *> *actionItems = [actionDescription objectForKey:FB_KEY_ACTIONS];
if (nil == actionItems || 0 == actionItems.count) {
NSString *description = [NSString stringWithFormat:@"It is mandatory to have at least one item defined for each action. Action with id '%@' contains none", actionId];
if (error) {
*error = [[FBErrorBuilder.builder withDescription:description] build];
}
return nil;
}

FBW3CKeyItemsChain *chain = [[FBW3CKeyItemsChain alloc] init];
NSArray<NSDictionary<NSString *, id> *> *processedItems = [self preprocessedActionItemsWith:actionItems];
for (NSDictionary<NSString *, id> *actionItem in processedItems) {
Expand Down Expand Up @@ -762,6 +770,14 @@ @implementation FBW3CActionsSynthesizer
}

NSArray<NSDictionary<NSString *, id> *> *actionItems = [actionDescription objectForKey:FB_KEY_ACTIONS];
if (nil == actionItems || 0 == actionItems.count) {
NSString *description = [NSString stringWithFormat:@"It is mandatory to have at least one gesture item defined for each action. Action with id '%@' contains none", actionId];
if (error) {
*error = [[FBErrorBuilder.builder withDescription:description] build];
}
return nil;
}

FBW3CGestureItemsChain *chain = [[FBW3CGestureItemsChain alloc] init];
NSArray<NSDictionary<NSString *, id> *> *processedItems = [self preprocessedActionItemsWith:actionItems];
for (NSDictionary<NSString *, id> *actionItem in processedItems) {
Expand Down
Loading