Add message to api exception and update JavaDocs for error codes #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderjordanbaker
force-pushed
the
AddMessageToApiError
branch
2 times, most recently
from
9e6ebd3 to
dfc6beb
Compare
izanger
reviewed
Dec 12, 2023
| } | ||
|
|
||
| public int getHttpStatusCode() { | ||
| return httpStatusCode; | ||
| } | ||
|
|
||
| public APIError getApiError() { | ||
| return apiError != null ? APIError.fetchErrorResponseFromErrorCode(apiError) : null; | ||
| return apiErrorCode != null ? APIError.fetchErrorResponseFromErrorCode(apiErrorCode) : null; | ||
| } | ||
|
|
||
| public Long getRawApiError() { |
There was a problem hiding this comment.
Suggest renaming to getRawApiErrorCode or just getApiErrorCode
There was a problem hiding this comment.
This is getting the raw apiError enum, hence the name
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "APIException{" + | ||
| "httpStatusCode=" + httpStatusCode + | ||
| ", apiError=" + apiError + | ||
| "} " + super.toString(); | ||
| ", apiError=" + apiErrorCode + |
There was a problem hiding this comment.
The public name for this field is apiError
izanger
reviewed
Dec 12, 2023
Add JavaDocs for the error codes
alexanderjordanbaker
force-pushed
the
AddMessageToApiError
branch
from
dfc6beb to
b04e4c0
Compare
izanger
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.