This repository has been archived by the owner on Feb 13, 2020. It is now read-only.
Docker for production #513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bebehei
reviewed
Jun 15, 2018
| @@ -0,0 +1,58 @@ | |||
|
|
|||
There was a problem hiding this comment.
Is this file actually a duplicate by accident?
There was a problem hiding this comment.
Not a duplicate: it maps the contrib/docker/samples/xml/conf to the /etc/caldavd/ VOLUME, to show how using XML to define resources is done. (And also how to override CCS configuration in general).
See line 20
|
Hi - just wanted to say that I haven't gotten around to trying this yet, but I definitely appreciate the contribution and will try to carve out some time for this soon! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Related to #489
Some key differences:
requirements-default.txtas bootstrap, should be usable in productionWith the kind help of @mschoengens we prepared a sample docker-compose which may be found in
contrib/docker.As for the
Dockerfile, I placed in root directory because this makes for the best scenario for using Docker during development (ie using Docker as the main build tool to make sure the image is always functioning).Whether to keep it there, I guess it all depends on how you like to work at Apple. If you do keep that file in root, what could be easily done is an integration with Docker Hub to have automated builds for the whole codebase.
An alternative could be to create a Docker build that retrieves the latest content from this GitHub repo instead, making it more "stable" and less developer-oriented.
Happy to discuss this if needed.
As a side note, I'm now working on an Helm chart to provide a setup similar to that of the docker-compose, but with LDAP, and HA for all services.
Cheers
Giorgio