quirks/websites-with-shared-credential-backends.json should be removed …

…#825 (#850)

Remove the file, remove references to the file, and update scripts that referenced it.

.github/workflows/lint-scripts/websites-shared-credentials-duplicates.rb

@@ -1,12 +1,22 @@
 require 'json'
 require 'set'
 
-shared_websites = JSON.parse(File.read('quirks/websites-with-shared-credential-backends.json'))
+KEYS = ["from", "to", "shared"]
+
+shared_credentials = JSON.parse(File.read('quirks/shared-credentials.json'))
+shared_credentials_historical = JSON.parse(File.read('quirks/shared-credentials-historical.json'))
+
+domains = []
+(shared_credentials + shared_credentials_historical).each do |entry|
+  KEYS.each do |key|
+    domains += entry[key] if entry[key]
+  end
+end
 
 seen_domains = Set.new
-shared_websites.flatten.each do |domain|
+domains.each do |domain|
   STDERR.puts "The domain '#{domain}' appears more than once!" if seen_domains.include?(domain)
   seen_domains << domain
 end
 
-exit(1) if seen_domains.count != shared_websites.flatten.count
+exit(1) if seen_domains.count != domains.count

.github/workflows/lint.yml

@@ -40,8 +40,6 @@ jobs:
       run: ruby .github/workflows/lint-scripts/websites-shared-credentials-sort-order.rb
     - name: Lint Duplicates
       run: ruby .github/workflows/lint-scripts/websites-shared-credentials-duplicates.rb
-    - name: Verify Generated Files
-      run: ruby tools/convert-shared-credential-to-legacy-format.rb --verify
 
   validate-schemas:
     runs-on: ubuntu-latest

CONTRIBUTING.md

@@ -51,8 +51,6 @@ Each entry in [`quirks/shared-credentials.json`](quirks/shared-credentials.json)
 
 When contributing or amending a set of websites sharing a credential backend, you should state why you believe the relevant domains do or do not share a credential backend, with evidence to support your claim. This may involve WHOIS information or content served from the domains themselves.
 
-[`quirks/websites-with-shared-credential-backends.json`](quirks/websites-with-shared-credential-backends.json) contains a lower fidelity version of the data in [`quirks/shared-credentials.json`](quirks/shared-credentials.json) and [`quirks/shared-credentials-historical.json`](quirks/shared-credentials-historical.json). It must be regenerated using [`tools/convert-shared-credential-to-legacy-format.rb`](tools/convert-shared-credential-to-legacy-format.rb) whenever those files are changed. Please do not edit [`quirks/websites-with-shared-credential-backends.json`](quirks/websites-with-shared-credential-backends.json) manually.
-
 ### Contributing a Change Password URL
 
 Use the website in question until you find the standalone page for updating the user's password, or a high-level "Account Information" or "Security" page. The closer the URL takes the user to be able to change their password, the better. Before adding a URL, ensure that it works properly both when the user is logged in and when they are not. URLs added to [`quirks/change-password-URLs.json`](quirks/change-password-URLs.json) should have a scheme of https unless the website does not allow changing the password on an https page.