Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Swift 5.7 build errors #707

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Fix Swift 5.7 build errors #707

merged 1 commit into from
Feb 7, 2025

Conversation

rgoldberg
Copy link
Contributor

@rgoldberg rgoldberg commented Feb 7, 2025

Fix Swift 5.7 build errors.

I used Swift.CustomStringConvertible instead of CustomStringConvertible because of a recommendation in the @retroactive Swift Proposal.

I know that you might want to move off of Swift 5.7 sometime, but can you please delay doing so until after a PR for #679 has been merged & released? Dropping support for 5.7 should require a major version bump.

Resolve #706

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

Resolve apple#706

Signed-off-by: Ross Goldberg <[email protected]>
@rauhul
Copy link
Contributor

rauhul commented Feb 7, 2025

@swift-ci test

@rauhul rauhul enabled auto-merge (squash) February 7, 2025 04:26
@rauhul rauhul merged commit aefbb6e into apple:main Feb 7, 2025
2 checks passed
@rgoldberg rgoldberg deleted the 706-swift-5.7 branch February 7, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swift 5.7 build errors
2 participants