Make OrderedSet.firstIndex ~4% faster by reducing ARC traffic #451
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrderedSet.firstIndex(of:)
runs into some retain/release overhead that make up ~4% of its runtime.Adding
@_effects(releasenone)
get's rid of this.I have personally never used
@_effects(releasenone)
before but I have seen it used throughout this project. If I understand its behavior correctly it should be safe to use it here but I'm not certain.Tested with
Checklist