Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for fieldmask utilities #1693

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Documentation for fieldmask utilities #1693

merged 5 commits into from
Aug 23, 2024

Conversation

pouyayarandi
Copy link
Contributor

This PR adds documentation for field mask utilities added in #1505

@thomasvl thomasvl requested a review from tbkka August 19, 2024 21:17
tbkka
tbkka approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty well written overall. I've marked a few places where I think it could be shortened. I've also noted one place where I think expanding an example would help make things clearer.

Documentation/API.md Outdated Show resolved Hide resolved
Documentation/API.md Outdated Show resolved Hide resolved
Documentation/API.md Outdated Show resolved Hide resolved
Documentation/API.md Outdated Show resolved Hide resolved
Documentation/API.md Outdated Show resolved Hide resolved
Documentation/API.md Outdated Show resolved Hide resolved
Documentation/API.md Show resolved Hide resolved
@thomasvl
Copy link
Collaborator

fyi - once the docs are in, I'll look at doing a release to get this and the access levels work out.

@pouyayarandi
Copy link
Contributor Author

pouyayarandi commented Aug 23, 2024 •
edited
Loading

All comments were fixed. Please check again @tbkka

tbkka
tbkka reviewed Aug 23, 2024
View reviewed changes
Documentation/API.md Outdated Show resolved Hide resolved
tbkka
tbkka reviewed Aug 23, 2024
View reviewed changes
Documentation/API.md Outdated Show resolved Hide resolved
tbkka
tbkka approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I'm happy to merge it as-is, though I did find a couple of very minor wording improvements that you could use if you want.

@tbkka tbkka merged commit 287f09b into apple:main Aug 23, 2024
9 of 10 checks passed
@tbkka
Copy link
Collaborator

tbkka commented Aug 23, 2024

Thanks for all the hard work here. I'm thrilled to get this out!

@pouyayarandi
Copy link
Contributor Author

It was my pleasure! I'm just as excited to see it out there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkka tbkka tbkka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pouyayarandi @thomasvl @tbkka