Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

[WIP] kwargs flow through for Image Similarity -> Nearest Neighbors #3233

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+94 −17
Open

[WIP] kwargs flow through for Image Similarity -> Nearest Neighbors #3233

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c36a277
kwargs flow through for image_similarity.create()
nishantnath Jun 22, 2020
ee6751f
Merge pull request #1 from nishantnath/img_sim_kwargs_patch
nishantnath Jun 22, 2020
0ec2937
adding link to nearest neighbors doc
nishantnath Jun 29, 2020
713f7b0
Merge pull request #2 from nishantnath/nishantnath-patch-2
nishantnath Jun 29, 2020
625d104
patches for tests
nishantnath Jun 29, 2020
304e82e
Merge pull request #3 from nishantnath/nishantnath-patch-3
nishantnath Jun 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/python/turicreate/toolkits/image_similarity/image_similarity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@


def create(
dataset, label=None, feature=None, model="resnet-50", verbose=True, batch_size=64
dataset,
label=None,
feature=None,
model="resnet-50",
verbose=True,
batch_size=64,
**kwargs
):
"""
Create a :class:`ImageSimilarityModel` model.
Expand Down Expand Up @@ -63,6 +69,9 @@ def create(
batch_size : int, optional
If you are getting memory errors, try decreasing this value. If you
have a powerful computer, increasing this value may improve performance.

**kwargs : optional
Options for downstream methods like tc.nearest_neighbors.create().
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change tc.nearest_neighbors.create() to :py:func:turicreate.nearest_neighbors.create()`. That will cause the text, in our API docs, to be linked to the appropriate documentation page for that function.


Returns
-------
Expand Down Expand Up @@ -148,6 +157,7 @@ def create(
label=label,
features=["__image_features__"],
verbose=verbose,
**kwargs
)

# set input image shape
Expand Down