Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wistia Support #20

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Wistia Support #20

wants to merge 5 commits into from

Conversation

cyberwani
Copy link

Added support for Wistia video.

@cyberwani cyberwani closed this May 14, 2018
@cyberwani cyberwani reopened this May 14, 2018
@RebliNk17
Copy link

RebliNk17 commented May 14, 2018

I needed wistia support, so i added it and finished about 5 hours ago, and you did the pull request after i finished...

@steelydylan
Copy link
Contributor

Hi @cyberwani
Thank you for adding the new video channel
but why do you have to add 'modal-video-opened' class to the body element?
I want you to remove that part.

@RebliNk17
Copy link

RebliNk17 commented May 15, 2018

@cyberwani
I think it is better to not use embedded api with wistia.
The way you did it, the user has no control on the video. the Wistia API is not working.
Maybe changing it to something like this is better
https://gist.github.com/RebliNk17/0b17822060157e17a32890a9225392a2

Just need to add a call to run "initVideo"

@cyberwani
Copy link
Author

Hi @steelydylan
I added 'modal-video-opened' class to handle some specific formatting in my one project when video popup is open, and I think it can be useful to the user. But, it's not necessary and can be removed.

@RebliNk17
I had already had a script in another project, and I was running on tight schedule, so I did integration like this. It can be changed to something better with flexible support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants